lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 190/475] drm/tegra: Fix reference leak in tegra_dsi_ganged_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 221e3638feb8bc42143833c9a704fa89b6c366bb ]

    The reference taken by 'of_find_device_by_node()' must be released when
    not needed anymore. Add put_device() call to fix this.

    Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/tegra/dsi.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
    index a5d47e301c5f..13413d2b2602 100644
    --- a/drivers/gpu/drm/tegra/dsi.c
    +++ b/drivers/gpu/drm/tegra/dsi.c
    @@ -1455,8 +1455,10 @@ static int tegra_dsi_ganged_probe(struct tegra_dsi *dsi)
    dsi->slave = platform_get_drvdata(gangster);
    of_node_put(np);

    - if (!dsi->slave)
    + if (!dsi->slave) {
    + put_device(&gangster->dev);
    return -EPROBE_DEFER;
    + }

    dsi->slave->master = dsi;
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:35    [W:3.162 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site