lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 185/475] scsi: pm8001: Fix payload initialization in pm80xx_set_thermal_config()
    Date
    From: Damien Le Moal <damien.lemoal@opensource.wdc.com>

    [ Upstream commit bb225b12dbcc82d53d637d10b8d70b64494f8c16 ]

    The fields of the set_ctrl_cfg_req structure have the __le32 type, so use
    cpu_to_le32() to assign them. This removes the sparse warnings:

    warning: incorrect type in assignment (different base types)
    expected restricted __le32
    got unsigned int

    Link: https://lore.kernel.org/r/20220220031810.738362-8-damien.lemoal@opensource.wdc.com
    Fixes: 842784e0d15b ("pm80xx: Update For Thermal Page Code")
    Fixes: f5860992db55 ("[SCSI] pm80xx: Added SPCv/ve specific hardware functionalities and relevant changes in common files")
    Reviewed-by: John Garry <john.garry@huawei.com>
    Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
    Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/pm8001/pm80xx_hwi.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
    index 5bf897188f4f..564be9754859 100644
    --- a/drivers/scsi/pm8001/pm80xx_hwi.c
    +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
    @@ -881,9 +881,11 @@ pm80xx_set_thermal_config(struct pm8001_hba_info *pm8001_ha)
    else
    page_code = THERMAL_PAGE_CODE_8H;

    - payload.cfg_pg[0] = (THERMAL_LOG_ENABLE << 9) |
    - (THERMAL_ENABLE << 8) | page_code;
    - payload.cfg_pg[1] = (LTEMPHIL << 24) | (RTEMPHIL << 8);
    + payload.cfg_pg[0] =
    + cpu_to_le32((THERMAL_LOG_ENABLE << 9) |
    + (THERMAL_ENABLE << 8) | page_code);
    + payload.cfg_pg[1] =
    + cpu_to_le32((LTEMPHIL << 24) | (RTEMPHIL << 8));

    rc = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &payload, 0);
    if (rc)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:35    [W:4.149 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site