lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 075/475] lib/raid6/test: fix multiple definition linking error
    Date
    From: Dirk Müller <dmueller@suse.de>

    commit a5359ddd052860bacf957e65fe819c63e974b3a6 upstream.

    GCC 10+ defaults to -fno-common, which enforces proper declaration of
    external references using "extern". without this change a link would
    fail with:

    lib/raid6/test/algos.c:28: multiple definition of `raid6_call';
    lib/raid6/test/test.c:22: first defined here

    the pq.h header that is included already includes an extern declaration
    so we can just remove the redundant one here.

    Cc: <stable@vger.kernel.org>
    Signed-off-by: Dirk Müller <dmueller@suse.de>
    Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
    Signed-off-by: Song Liu <song@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    lib/raid6/test/test.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/lib/raid6/test/test.c
    +++ b/lib/raid6/test/test.c
    @@ -19,7 +19,6 @@
    #define NDISKS 16 /* Including P and Q */

    const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
    -struct raid6_calls raid6_call;

    char *dataptrs[NDISKS];
    char data[NDISKS][PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));

    \
     
     \ /
      Last update: 2022-04-14 16:34    [W:2.745 / U:1.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site