lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 106/475] hwmon: (pmbus) Add Vin unit off handling
    Date
    From: Brandon Wyman <bjwyman@gmail.com>

    [ Upstream commit a5436af598779219b375c1977555c82def1c35d0 ]

    If there is an input undervoltage fault, reported in STATUS_INPUT
    command response, there is quite likely a "Unit Off For Insufficient
    Input Voltage" condition as well.

    Add a constant for bit 3 of STATUS_INPUT. Update the Vin limit
    attributes to include both bits in the mask for clearing faults.

    If an input undervoltage fault occurs, causing a unit off for
    insufficient input voltage, but the unit is off bit is not cleared, the
    STATUS_WORD will not be updated to clear the input fault condition.
    Including the unit is off bit (bit 3) allows for the input fault
    condition to completely clear.

    Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
    Link: https://lore.kernel.org/r/20220317232123.2103592-1-bjwyman@gmail.com
    Fixes: b4ce237b7f7d3 ("hwmon: (pmbus) Introduce infrastructure to detect sensors and limit registers")
    [groeck: Dropped unnecessary ()]
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/pmbus/pmbus.h | 1 +
    drivers/hwmon/pmbus/pmbus_core.c | 2 +-
    2 files changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h
    index d198af3a92b6..9731f1f830b1 100644
    --- a/drivers/hwmon/pmbus/pmbus.h
    +++ b/drivers/hwmon/pmbus/pmbus.h
    @@ -292,6 +292,7 @@ enum pmbus_fan_mode { percent = 0, rpm };
    /*
    * STATUS_VOUT, STATUS_INPUT
    */
    +#define PB_VOLTAGE_VIN_OFF BIT(3)
    #define PB_VOLTAGE_UV_FAULT BIT(4)
    #define PB_VOLTAGE_UV_WARNING BIT(5)
    #define PB_VOLTAGE_OV_WARNING BIT(6)
    diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
    index b2dfbd1cb543..beb443d020c2 100644
    --- a/drivers/hwmon/pmbus/pmbus_core.c
    +++ b/drivers/hwmon/pmbus/pmbus_core.c
    @@ -1324,7 +1324,7 @@ static const struct pmbus_limit_attr vin_limit_attrs[] = {
    .reg = PMBUS_VIN_UV_FAULT_LIMIT,
    .attr = "lcrit",
    .alarm = "lcrit_alarm",
    - .sbit = PB_VOLTAGE_UV_FAULT,
    + .sbit = PB_VOLTAGE_UV_FAULT | PB_VOLTAGE_VIN_OFF,
    }, {
    .reg = PMBUS_VIN_OV_WARN_LIMIT,
    .attr = "max",
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:34    [W:2.488 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site