lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 124/475] soc: ti: wkup_m3_ipc: Fix IRQ check in wkup_m3_ipc_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit c3d66a164c726cc3b072232d3b6d87575d194084 ]

    platform_get_irq() returns negative error number instead 0 on failure.
    And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
    return irq;

    Fix the check of return value to catch errors correctly.

    Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Nishanth Menon <nm@ti.com>
    Acked-by: Dave Gerlach <d-gerlach@ti.com>
    Link: https://lore.kernel.org/r/20220114062840.16620-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/ti/wkup_m3_ipc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
    index e9ece45d7a33..ef3f95fefab5 100644
    --- a/drivers/soc/ti/wkup_m3_ipc.c
    +++ b/drivers/soc/ti/wkup_m3_ipc.c
    @@ -447,9 +447,9 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
    }

    irq = platform_get_irq(pdev, 0);
    - if (!irq) {
    + if (irq < 0) {
    dev_err(&pdev->dev, "no irq resource\n");
    - return -ENXIO;
    + return irq;
    }

    ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:31    [W:4.259 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site