lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 122/475] soc: qcom: aoss: remove spurious IRQF_ONESHOT flags
    Date
    From: Daniel Thompson <daniel.thompson@linaro.org>

    [ Upstream commit 8030cb9a55688c1339edd284d9d6ce5f9fc75160 ]

    Quoting the header comments, IRQF_ONESHOT is "Used by threaded interrupts
    which need to keep the irq line disabled until the threaded handler has
    been run.". When applied to an interrupt that doesn't request a threaded
    irq then IRQF_ONESHOT has a lesser known (undocumented?) side effect,
    which it to disable the forced threading of the irq. For "normal" kernels
    (without forced threading) then, if there is no thread_fn, then
    IRQF_ONESHOT is a nop.

    In this case disabling forced threading is not appropriate for this driver
    because it calls wake_up_all() and this API cannot be called from
    no-thread interrupt handlers on PREEMPT_RT systems (deadlock risk, triggers
    sleeping-while-atomic warnings).

    Fix this by removing IRQF_ONESHOT.

    Fixes: 2209481409b7 ("soc: qcom: Add AOSS QMP driver")
    Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
    [bjorn: Added Fixes tag]
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220127173554.158111-1-daniel.thompson@linaro.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/qcom_aoss.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
    index 45c5aa712eda..f16d6ec78064 100644
    --- a/drivers/soc/qcom/qcom_aoss.c
    +++ b/drivers/soc/qcom/qcom_aoss.c
    @@ -544,7 +544,7 @@ static int qmp_probe(struct platform_device *pdev)
    }

    irq = platform_get_irq(pdev, 0);
    - ret = devm_request_irq(&pdev->dev, irq, qmp_intr, IRQF_ONESHOT,
    + ret = devm_request_irq(&pdev->dev, irq, qmp_intr, 0,
    "aoss-qmp", qmp);
    if (ret < 0) {
    dev_err(&pdev->dev, "failed to request interrupt\n");
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:23    [W:3.751 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site