lkml.org 
[lkml]   [2022]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 108/475] sched/debug: Remove mpol_get/put and task_lock/unlock from sched_show_numa
    Date
    From: Bharata B Rao <bharata@amd.com>

    [ Upstream commit 28c988c3ec29db74a1dda631b18785958d57df4f ]

    The older format of /proc/pid/sched printed home node info which
    required the mempolicy and task lock around mpol_get(). However
    the format has changed since then and there is no need for
    sched_show_numa() any more to have mempolicy argument,
    asssociated mpol_get/put and task_lock/unlock. Remove them.

    Fixes: 397f2378f1361 ("sched/numa: Fix numa balancing stats in /proc/pid/sched")
    Signed-off-by: Bharata B Rao <bharata@amd.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
    Acked-by: Mel Gorman <mgorman@suse.de>
    Link: https://lore.kernel.org/r/20220118050515.2973-1-bharata@amd.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/sched/debug.c | 10 ----------
    1 file changed, 10 deletions(-)

    diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
    index faada713cfae..d5f7fc7099bc 100644
    --- a/kernel/sched/debug.c
    +++ b/kernel/sched/debug.c
    @@ -847,25 +847,15 @@ void print_numa_stats(struct seq_file *m, int node, unsigned long tsf,
    static void sched_show_numa(struct task_struct *p, struct seq_file *m)
    {
    #ifdef CONFIG_NUMA_BALANCING
    - struct mempolicy *pol;
    -
    if (p->mm)
    P(mm->numa_scan_seq);

    - task_lock(p);
    - pol = p->mempolicy;
    - if (pol && !(pol->flags & MPOL_F_MORON))
    - pol = NULL;
    - mpol_get(pol);
    - task_unlock(p);
    -
    P(numa_pages_migrated);
    P(numa_preferred_nid);
    P(total_numa_faults);
    SEQ_printf(m, "current_node=%d, numa_group_id=%d\n",
    task_node(p), task_numa_group_id(p));
    show_numa_stats(p, m);
    - mpol_put(pol);
    #endif
    }

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-14 16:23    [W:2.661 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site