Messages in this thread | | | Date | Wed, 13 Apr 2022 08:38:41 -0700 | Subject | Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID | From | Florian Fainelli <> |
| |
On 4/12/2022 4:32 AM, Andy Shevchenko wrote: > There is export_uuid() function which exports uuid_t to the u8 array. > Use it instead of open coding variant. > > This allows to hide the uuid_t internals. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v3: rebased on the latest vanilla, added Andrew since it has no move for 1y+
I don't think this is going to be picked up unless we designate a entry in the MAINTAINERS file, I don't mind taking this via the Broadcom ARM SoCs pull request if this does not move.
> drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c > index a5bf4c3f6dc7..40e3183a3d11 100644 > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c > @@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev) > return -ENODEV; > > /* Open session with Bnxt load Trusted App */ > - memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN); > + export_uuid(sess_arg.uuid, &bnxt_device->id.uuid); > sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC; > sess_arg.num_params = 0; >
-- Florian
| |