Messages in this thread | | | Date | Wed, 13 Apr 2022 16:49:54 +0200 | From | Herve Codina <> | Subject | Re: [PATCH 1/6] PCI: rcar-gen2: Add support for clocks |
| |
Hi Rob,
On Tue, 12 Apr 2022 10:50:10 -0500 Rob Herring <robh@kernel.org> wrote:
> On Tue, Apr 12, 2022 at 11:40:24AM +0200, Herve Codina wrote: > > The PCI rcar-gen2 does not call any clk_prepare_enable(). > > This lead to an access failure when the driver tries to access > > the IP (at least on a RZ/N1D platform). > > > > Prepare and enable clocks using the bulk version of > > clk_prepare_enable() in order to prepare and enable all clocks > > attached to this device. > > The binding says there is only a single clock, so it needs an update if > there are multiple clocks. (And ideally converted to DT schema format.)
Indeed, I will convert to DT schema format and update the clocks property description.
Regards, Hervé
| |