Messages in this thread | | | Date | Wed, 13 Apr 2022 16:16:17 +0200 | Subject | Re: [PATCH v2 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x | From | Camel Guo <> |
| |
On 4/13/22 15:34, Rob Herring wrote: > On Wed, Apr 13, 2022 at 09:13:39AM +0000, Camel Guo wrote: >> On 4/12/22 23:36, Rob Herring wrote: >> > On Tue, Apr 12, 2022 at 03:52:31PM +0200, Camel Guo wrote: >> >> Document the TMP401, TMP411 and TMP43x device devicetree bindings >> >> >> >> + maximum: 15 >> > >> > Drop 'items'. It is not an array. >> >> Not sure if I understand correctly. Do you means it should be like this? >> If so, I guess ti,n-factor should also be changed like this. Am I right? >> >> ti,beta-compensation: >> description: >> value to select beta correction range. >> $ref: /schemas/types.yaml#/definitions/uint32 >> minimum: 0 >> maximum: 15 > > Yes, except your indentation is off. As-is, it's all 'description'. It > should be like this: > > ti,beta-compensation: > description: > value to select beta correction range. > $ref: /schemas/types.yaml#/definitions/uint32 > minimum: 0 > maximum: 15 > > Rob
Now v3 is out with fixes on Rob's comments. Please review v3 instead.
| |