Messages in this thread | | | Date | Wed, 13 Apr 2022 07:07:40 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor' |
| |
On Wed, Apr 13, 2022 at 08:47:29AM -0500, Rob Herring wrote: > 'ti,n-factor' is read as a 32-bit signed value, so the type and constraints > are wrong. The same property is also defined for ti,tmp464 and is correct. > > The constraints should also not be under 'items' as this property is not an > array. > > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: linux-hwmon@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org>
Applied.
Thanks, Guenter
> --- > Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml > index 36f649938fb7..a6f1fa75a67c 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml > @@ -58,10 +58,9 @@ patternProperties: > description: | > The value (two's complement) to be programmed in the channel specific N correction register. > For remote channels only. > - $ref: /schemas/types.yaml#/definitions/uint32 > - items: > - minimum: 0 > - maximum: 255 > + $ref: /schemas/types.yaml#/definitions/int32 > + minimum: -128 > + maximum: 127 > > required: > - reg
| |