lkml.org 
[lkml]   [2022]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/2] staging: greybus: remove empty callback function
From
On 4/12/22 11:38 PM, Jaehee Park wrote:
> Remove the optional remove callback for the soc_codec_dev_gbaudio
> structure. The only place it is referenced is
> snd_soc_component_remove() which is only called if the sound_component
> pointer is non-null. The null function pointers here can be optionally
> ommitted. When a sound component is registered this way, the remove
> callback is optional. We can safely remove the whole gbcodec_remove
> function, which used to be an empty function with a void return type.

Now I think your description is a little long... But that's OK.

This looks good to me. Thank you for responding to all our
feedback.

Reviewed-by: Alex Elder <elder@linaro.org>
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
> ---
> drivers/staging/greybus/audio_codec.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 0f50d1e51e2c..dc030caa64ba 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -1029,12 +1029,6 @@ static int gbcodec_probe(struct snd_soc_component *comp)
> return 0;
> }
>
> -static void gbcodec_remove(struct snd_soc_component *comp)
> -{
> - /* Empty function for now */
> - return;
> -}
> -
> static int gbcodec_write(struct snd_soc_component *comp, unsigned int reg,
> unsigned int value)
> {
> @@ -1049,8 +1043,6 @@ static unsigned int gbcodec_read(struct snd_soc_component *comp,
>
> static const struct snd_soc_component_driver soc_codec_dev_gbaudio = {
> .probe = gbcodec_probe,
> - .remove = gbcodec_remove,
> -
> .read = gbcodec_read,
> .write = gbcodec_write,
> };

\
 
 \ /
  Last update: 2022-04-13 14:49    [W:0.127 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site