lkml.org 
[lkml]   [2022]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 0/2] memory: omap-gpmc: Allow module build
From
On 13/04/2022 14:05, Krzysztof Kozlowski wrote:
> On 13/04/2022 13:01, Roger Quadros wrote:
>>> https://krzk.eu/#/builders/63/builds/162
>>>
>>>
>>>> config OMAP_GPMC
>>>> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>>>> - depends on OF_ADDRESS
>>>> + bool "Texas Instruments OMAP SoC GPMC driver"
>>>> + depends on OF_ADDRESS || COMPILE_TEST
>>
>>
>> Looks like include/linux/irqdomain.h does not have fallbacks if
>> CONFIG_IRQ_DOMAIN is not enabled.
>>
>> I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN.
>> Is that OK?
>
> Previously it was building with COMPILE_TEST on sparc, so what else changed?
>
Previously it was like so

bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
depends on OF_ADDRESS

Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set.

And OF_ADDRESS is not set for sparc

config OF_ADDRESS
def_bool y
depends on !SPARC && (HAS_IOMEM || UML)

cheers,
-roger

\
 
 \ /
  Last update: 2022-04-13 13:34    [W:0.074 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site