lkml.org 
[lkml]   [2022]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 0/2] memory: omap-gpmc: Allow module build
From
On 13/04/2022 13:20, Krzysztof Kozlowski wrote:
> On 13/04/2022 11:50, Krzysztof Kozlowski wrote:
>> On 13/04/2022 11:43, Krzysztof Kozlowski wrote:
>>> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote:
>>>> These patches allow OMAP_GPMC config to be visible in menuconfig
>>>> and buildable as a module.
>>>>
>>>> Changelog:
>>>> v3:
>>>> - Remove not required MODULE_ALIAS
>>>> - Mention in commit message why we need to remove of_match_node() call
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable
>>> commit: 656d1be692be78b825954e0a2a47fcae81834633
>>> [2/2] memory: omap-gpmc: Allow building as a module
>>> commit: eb55c7180be67774aa728a3c450de441e0dedb5d
>>
>> And dropped. You have a checkpatch issue:
>>
>> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module:
>> Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
>> #127: FILE: drivers/memory/omap-gpmc.c:2664:
>> +MODULE_LICENSE("GPL v2");
>
> I kept your first patch (visible/selectable) but I think it should be
> dropped as well. You need to test it more:
>
> https://krzk.eu/#/builders/63/builds/162
>
>
>> config OMAP_GPMC
>> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>> - depends on OF_ADDRESS
>> + bool "Texas Instruments OMAP SoC GPMC driver"
>> + depends on OF_ADDRESS || COMPILE_TEST


Looks like include/linux/irqdomain.h does not have fallbacks if
CONFIG_IRQ_DOMAIN is not enabled.

I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN.
Is that OK?

cheers,
-roger

\
 
 \ /
  Last update: 2022-04-13 13:02    [W:0.070 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site