Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 13 Apr 2022 12:38:26 +0200 | Subject | Re: [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers |
| |
Hi Javier,
On Wed, Apr 13, 2022 at 11:44 AM Javier Martinez Canillas <javierm@redhat.com> wrote: > On 4/13/22 10:04, Geert Uytterhoeven wrote: > > On Tue, Apr 12, 2022 at 6:27 PM Javier Martinez Canillas > > <javierm@redhat.com> wrote: > >> The Solomon SSD130x OLED displays can either have an I2C or SPI interface, > >> add to the schema the properties and examples for OLED devices under SPI. > >> > >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > >> Acked-by: Mark Brown <broonie@kernel.org> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> --- > >> > >> Changes in v3: > >> - Add a comment to the properties required for SPI (Geert Uytterhoeven) > > > > Thanks for the update! > > > >> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > >> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > >> @@ -38,9 +38,16 @@ properties: > >> reset-gpios: > >> maxItems: 1 > >> > >> + # Only required for SPI > >> + dc-gpios: > >> + maxItems: 1 > > > > Actually I meant to also add a description, like for vbat-supply below, > > to explain the meaning of "dc". > > > > Ahh, sorry for misunderstanding you! Something like the following looks good ? > > # Only required for SPI > dc-gpios: > description: > GPIO connected to the controller's D/C# (Data/Command) pin, > that is needed for 4-wire SPI to tell the controller if the > data sent is for a command register or the display data RAM > maxItems: 1 > > If you agree with that, then can squash before pushing or add it to a v4 > if another revision is needed.
Thanks, LGTM.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |