lkml.org 
[lkml]   [2022]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 2/2] watchdog: Add Renesas RZ/N1 Watchdog driver
From

On 11/04/2022 03:50, Tzung-Bi Shih wrote:
> On Fri, Apr 08, 2022 at 10:02:05PM +0200, Jean-Jacques Hiblot wrote:
>> From: Phil Edworthy <phil.edworthy@renesas.com>
>>
>> This is a driver for the standard WDT on the RZ/N1 devices. This WDT has
>> very limited timeout capabilities. However, it can reset the device.
>> To do so, the corresponding bits in the SysCtrl RSTEN register need to
>> be enabled. This is not done by this driver.
>>
>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> With a minor comment:
> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

Thanks for the time you took reviewing this.

>
>> +static int rzn1_wdt_probe(struct platform_device *pdev)
>> +{
> [...]
>> + wdt->wdtdev.timeout = DEFAULT_TIMEOUT;
>> + ret = watchdog_init_timeout(&wdt->wdtdev, 0, dev);
> Could it drop the assignment if `ret` is unused?

I'll keep the assignment but check the value: watchdog_timeout_invalid()

will return an error if the dt supplied value is out of range.

JJ


\
 
 \ /
  Last update: 2022-04-13 09:56    [W:0.381 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site