Messages in this thread | | | Date | Thu, 14 Apr 2022 10:37:51 +0800 | From | Leo Yan <> | Subject | Re: [PATCH] perf arm-spe: Test memory samples |
| |
On Wed, Apr 13, 2022 at 06:17:18PM +0100, German Gomez wrote: > > On 13/04/2022 02:02, Leo Yan wrote: > > Add a new test to verify the Arm SPE synthesized memory samples with > > 'perf mem report' command. > > > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > Reviewed-by: German Gomez <german.gomez@arm.com>
Thanks for reviewing.
> Thanks for the patch. > > There are some tests for perf_event_attr fields. We added one for SPE > recently [1], but it's not checking the sample_type attribute yet. > > We could update it from our side and send another patch, to test the > DATA_SRC bit is not missing.
Agreed, it's better to update the patch for checking DATA_SRC bit and resend it. Thanks!
Leo
> [1] https://lore.kernel.org/all/20220126160710.32983-1-german.gomez@arm.com/
| |