lkml.org 
[lkml]   [2022]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/18] objtool: Print data address for "!ENDBR" data warnings
    Date
    When a "!ENDBR" warning is reported for a data section, objtool just
    prints the text address of the relocation target twice, without giving
    any clues about the location of the original data reference:

    vmlinux.o: warning: objtool: dcbnl_netdevice_event()+0x0: .text+0xb64680: data relocation to !ENDBR: dcbnl_netdevice_event+0x0

    Instead, print the address of the data reference, in addition to the
    address of the relocation target.

    vmlinux.o: warning: objtool: dcbnl_nb+0x0: .data..read_mostly+0xe260: data relocation to !ENDBR: dcbnl_netdevice_event+0x0

    Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    ---
    tools/objtool/check.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/tools/objtool/check.c b/tools/objtool/check.c
    index 5bd3aa815d51..7a1a02dacb77 100644
    --- a/tools/objtool/check.c
    +++ b/tools/objtool/check.c
    @@ -3825,11 +3825,8 @@ static int validate_ibt(struct objtool_file *file)
    struct instruction *dest;

    dest = validate_ibt_reloc(file, reloc);
    - if (is_data && dest && !dest->noendbr) {
    - warn_noendbr("data ", reloc->sym->sec,
    - reloc->sym->offset + reloc->addend,
    - dest);
    - }
    + if (is_data && dest && !dest->noendbr)
    + warn_noendbr("data ", sec, reloc->offset, dest);
    }
    }

    --
    2.34.1
    \
     
     \ /
      Last update: 2022-04-14 01:21    [W:4.180 / U:1.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site