Messages in this thread | | | Subject | Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap | From | Bean Huo <> | Date | Wed, 13 Apr 2022 23:29:53 +0200 |
| |
Hi, Po wen and Peter
I must give this patch Ack, because:
1. “fHPBReset Flag” can be sent in both host control mode and device control mode. “buffer id=3 HpbWriteBuffer” can only be sent in device control mode.
2. “fHPBReset Flag” inactivate all the regions for the whole device. “buffer id=3 HpbWriteBuffer” can only inactivate all the regions for this LUN. The LUN is written in the UPIU header.
In the ufshpb_init, we have set fHPBReset Flag. here doesn't need to issue “buffer id=3 HpbWriteBuffer” in the case of device mode.
Regarding the reset flow issue we are talking about, I will submit a fix.
Acked-by: Bean Huo <beanhuo@micron.com>
Bean
| |