Messages in this thread | | | Date | Wed, 13 Apr 2022 22:40:39 +0300 | Subject | Re: [PATCH v6 09/18] clk: qcom: krait-cc: drop pr_info and register qsb only if needed | From | Dmitry Baryshkov <> |
| |
On 22/03/2022 02:15, Ansuel Smith wrote: > Replace pr_info() with dev_info() to provide better diagnostics. > Register qsb fixed clk only if it's not declared in DTS.
This can be split into two patches
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > drivers/clk/qcom/krait-cc.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/qcom/krait-cc.c b/drivers/clk/qcom/krait-cc.c > index 645ad9e8dd73..e9508e3104ea 100644 > --- a/drivers/clk/qcom/krait-cc.c > +++ b/drivers/clk/qcom/krait-cc.c > @@ -308,7 +308,9 @@ static int krait_cc_probe(struct platform_device *pdev) > return -ENODEV; > > /* Rate is 1 because 0 causes problems for __clk_mux_determine_rate */ > - clk = clk_register_fixed_rate(dev, "qsb", NULL, 0, 1); > + if (IS_ERR(clk_get(dev, "qsb"))) > + clk = clk_register_fixed_rate(dev, "qsb", NULL, 0, 1); > + > if (IS_ERR(clk)) > return PTR_ERR(clk); > > @@ -363,25 +365,25 @@ static int krait_cc_probe(struct platform_device *pdev) > cur_rate = clk_get_rate(l2_pri_mux_clk); > aux_rate = 384000000; > if (cur_rate == 1) { > - pr_info("L2 @ QSB rate. Forcing new rate.\n"); > + dev_info(dev, "L2 @ QSB rate. Forcing new rate.\n"); > cur_rate = aux_rate; > } > clk_set_rate(l2_pri_mux_clk, aux_rate); > clk_set_rate(l2_pri_mux_clk, 2); > clk_set_rate(l2_pri_mux_clk, cur_rate); > - pr_info("L2 @ %lu KHz\n", clk_get_rate(l2_pri_mux_clk) / 1000); > + dev_info(dev, "L2 @ %lu KHz\n", clk_get_rate(l2_pri_mux_clk) / 1000); > for_each_possible_cpu(cpu) { > clk = clks[cpu]; > cur_rate = clk_get_rate(clk); > if (cur_rate == 1) { > - pr_info("CPU%d @ QSB rate. Forcing new rate.\n", cpu); > + dev_info(dev, "CPU%d @ QSB rate. Forcing new rate.\n", cpu); > cur_rate = aux_rate; > } > > clk_set_rate(clk, aux_rate); > clk_set_rate(clk, 2); > clk_set_rate(clk, cur_rate); > - pr_info("CPU%d @ %lu KHz\n", cpu, clk_get_rate(clk) / 1000); > + dev_info(dev, "CPU%d @ %lu KHz\n", cpu, clk_get_rate(clk) / 1000); > } > > of_clk_add_provider(dev->of_node, krait_of_get, clks);
-- With best wishes Dmitry
| |