Messages in this thread | | | Date | Tue, 12 Apr 2022 09:10:26 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v10 08/14] mm: multi-gen LRU: support page table walks |
| |
On Mon, Apr 11, 2022 at 07:16:21PM -0700, Andrew Morton wrote: > On Wed, 6 Apr 2022 21:15:20 -0600 Yu Zhao <yuzhao@google.com> wrote:
> > +#ifdef CONFIG_LRU_GEN > > +static void mem_cgroup_attach(struct cgroup_taskset *tset) > > +{ > > + struct cgroup_subsys_state *css; > > + struct task_struct *task = NULL; > > + > > + cgroup_taskset_for_each_leader(task, css, tset) > > + break; > > Does this actually do anything?
Yeah, it finds the first leader if there is any, but this is indeed quite terrible coding style.
| |