lkml.org 
[lkml]   [2022]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 020/343] drm/amd/amdgpu/amdgpu_cs: fix refcount leak of a dma_fence obj
    Date
    From: Xin Xiong <xiongx18@fudan.edu.cn>

    [ Upstream commit dfced44f122c500004a48ecc8db516bb6a295a1b ]

    This issue takes place in an error path in
    amdgpu_cs_fence_to_handle_ioctl(). When `info->in.what` falls into
    default case, the function simply returns -EINVAL, forgetting to
    decrement the reference count of a dma_fence obj, which is bumped
    earlier by amdgpu_cs_get_fence(). This may result in reference count
    leaks.

    Fix it by decreasing the refcount of specific object before returning
    the error code.

    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
    Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
    index 06d07502a1f6..a34be65c9eaa 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
    @@ -1509,6 +1509,7 @@ int amdgpu_cs_fence_to_handle_ioctl(struct drm_device *dev, void *data,
    return 0;

    default:
    + dma_fence_put(fence);
    return -EINVAL;
    }
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-04-12 10:26    [W:4.392 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site