lkml.org 
[lkml]   [2022]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 03/18] ARM: dts: qcom: add missing rpm regulators and cells for ipq8064
    On Wed 09 Mar 13:01 CST 2022, Ansuel Smith wrote:

    > Add cells definition for rpm node

    Why do we need the cells?

    > and add missing regulators for the 4
    > regulator present on ipq8064. There regulators are controlled by rpm and
    > to correctly works gsbi4_i2c require to be NEVER disabled or rpm will

    Are you saying "...to correctly work, gsbi4_i2c must NEVER be disabled..."?

    If so, that's good information, but how does it relate to this
    particular change?

    Regards,
    Bjorn

    > reject any regulator change request.
    >
    > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
    > Tested-by: Jonathan McDowell <noodles@earth.li>
    > ---
    > arch/arm/boot/dts/qcom-ipq8064.dtsi | 36 +++++++++++++++++++++++++++++
    > 1 file changed, 36 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
    > index b309bc0fbbcd..0938838a4af8 100644
    > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
    > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
    > @@ -842,10 +842,46 @@ rpm: rpm@108000 {
    > clocks = <&gcc RPM_MSG_RAM_H_CLK>;
    > clock-names = "ram";
    >
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > +
    > rpmcc: clock-controller {
    > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc";
    > #clock-cells = <1>;
    > };
    > +
    > + smb208_regulators: regulators {
    > + compatible = "qcom,rpm-smb208-regulators";
    > + status = "okay";
    > +
    > + smb208_s1a: s1a {
    > + regulator-min-microvolt = <1050000>;
    > + regulator-max-microvolt = <1150000>;
    > +
    > + qcom,switch-mode-frequency = <1200000>;
    > + };
    > +
    > + smb208_s1b: s1b {
    > + regulator-min-microvolt = <1050000>;
    > + regulator-max-microvolt = <1150000>;
    > +
    > + qcom,switch-mode-frequency = <1200000>;
    > + };
    > +
    > + smb208_s2a: s2a {
    > + regulator-min-microvolt = < 800000>;
    > + regulator-max-microvolt = <1250000>;
    > +
    > + qcom,switch-mode-frequency = <1200000>;
    > + };
    > +
    > + smb208_s2b: s2b {
    > + regulator-min-microvolt = < 800000>;
    > + regulator-max-microvolt = <1250000>;
    > +
    > + qcom,switch-mode-frequency = <1200000>;
    > + };
    > + };
    > };
    >
    > tcsr: syscon@1a400000 {
    > --
    > 2.34.1
    >

    \
     
     \ /
      Last update: 2022-04-12 21:53    [W:4.285 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site