lkml.org 
[lkml]   [2022]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] usb: usbip: fix a refcount leak in stub_probe()
From
Date
On 4/11/22 8:02 PM, Hangyu Hua wrote:
> usb_get_dev() is called in stub_device_alloc(). When stub_probe() fails
> after that, usb_put_dev() needs to be called to release the reference.
>
> Fix this by moving usb_put_dev() to sdev_free error path handling.
>
> Find this by code review.
>
> Fixes: 3ff67445750a ("usbip: fix error handling in stub_probe()")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
>
> v2: add more description of this patch.
>
> v3: add how to find the problem.
>

Thank you.

Greg, Please pick this patch up.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2022-04-12 16:45    [W:0.042 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site