Messages in this thread | | | Date | Tue, 12 Apr 2022 15:16:35 +0530 | Subject | Re: [RFC 13/13] net: ti: icssg-prueth: Add ICSSG ethernet driver | From | Puranjay Mohan <> |
| |
+Roger, Grygorii
On 07/04/22 00:12, Andrew Lunn wrote: >> +config TI_ICSSG_PRUETH >> + tristate "TI Gigabit PRU Ethernet driver" >> + select TI_DAVINCI_MDIO >> + > > I don't see a dependency on TI_DAVINCI_MDIO in the code. All you need > is an MDIO bus so that your phy-handle has somewhere to point. But that > could be a GPIO bit banger. > > What i do think is missing here is a dependency on PHYLIB. > > If possible, it would be good to also have it compile when > COMPILE_TEST is set. > > Andrew
| |