lkml.org 
[lkml]   [2022]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC 13/13] net: ti: icssg-prueth: Add ICSSG ethernet driver
From
+Roger, Grygorii

On 07/04/22 00:12, Andrew Lunn wrote:
>> +config TI_ICSSG_PRUETH
>> + tristate "TI Gigabit PRU Ethernet driver"
>> + select TI_DAVINCI_MDIO
>> +
>
> I don't see a dependency on TI_DAVINCI_MDIO in the code. All you need
> is an MDIO bus so that your phy-handle has somewhere to point. But that
> could be a GPIO bit banger.
>
> What i do think is missing here is a dependency on PHYLIB.
>
> If possible, it would be good to also have it compile when
> COMPILE_TEST is set.
>
> Andrew

\
 
 \ /
  Last update: 2022-04-12 12:48    [W:0.079 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site