lkml.org 
[lkml]   [2022]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] soc: ti: knav_dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
From


On 12/04/2022 11:29, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/soc/ti/knav_dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index 700d8eecd8c4..061f92c8cf7d 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -747,9 +747,8 @@ static int knav_dma_probe(struct platform_device *pdev)
> INIT_LIST_HEAD(&kdev->list);
>
> pm_runtime_enable(kdev->dev);
> - ret = pm_runtime_get_sync(kdev->dev);
> + ret = pm_runtime_resume_and_get(kdev->dev);
> if (ret < 0) {
> - pm_runtime_put_noidle(kdev->dev);
> dev_err(kdev->dev, "unable to enable pktdma, err %d\n", ret);
> goto err_pm_disable;
> }

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

--
Best regards,
Grygorii, Ukraine

\
 
 \ /
  Last update: 2022-04-12 11:49    [W:0.046 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site