lkml.org 
[lkml]   [2022]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 158/343] staging: vchiq_arm: Avoid NULL ptr deref in vchiq_dump_platform_instances
    Date
    From: Stefan Wahren <stefan.wahren@i2se.com>

    [ Upstream commit aa899e686d442c63d50f4d369cc02dbbf0941cb0 ]

    vchiq_get_state() can return a NULL pointer. So handle this cases and
    avoid a NULL pointer derefence in vchiq_dump_platform_instances.

    Reviewed-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
    Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
    Link: https://lore.kernel.org/r/1642968143-19281-17-git-send-email-stefan.wahren@i2se.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
    index 3a2e4582db8e..a3e3c9f9aa18 100644
    --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
    +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
    @@ -1209,6 +1209,9 @@ int vchiq_dump_platform_instances(void *dump_context)
    int len;
    int i;

    + if (!state)
    + return -ENOTCONN;
    +
    /*
    * There is no list of instances, so instead scan all services,
    * marking those that have been dumped.
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-04-12 10:53    [W:4.592 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site