Messages in this thread | | | Subject | Re: [PATCH v5 3/5] perf tools: sync addition of PERF_MEM_SNOOPX_PEER | From | German Gomez <> | Date | Mon, 11 Apr 2022 15:35:52 +0100 |
| |
On 11/04/2022 11:26, German Gomez wrote: > On 08/04/2022 20:53, Ali Saidi wrote: >> Add a flag to the perf mem data struct to signal that a request caused a >> cache-to-cache transfer of a line from a peer of the requestor and >> wasn't sourced from a lower cache level. The line being moved from one >> peer cache to another has latency and performance implications. On Arm64 >> Neoverse systems the data source can indicate a cache-to-cache transfer >> but not if the line is dirty or clean, so instead of overloading HITM >> define a new flag that indicates this type of transfer. > I think it's fine to merge this and the previous commit rather than have > two commits with the same msg. >
I take it back. It has been pointed out to me that having the separation is normal/ok. So my comment doesn't apply.
| |