Messages in this thread Patch in this message | | | From | HORIGUCHI NAOYA(堀口 直也) <> | Subject | Re: [PATCH 2/3] mm/memory-failure.c: minor cleanup for HWPoisonHandlable | Date | Mon, 11 Apr 2022 13:14:13 +0000 |
| |
On Thu, Apr 07, 2022 at 09:03:51PM +0800, Miaohe Lin wrote: > The local variable movable can be removed by returning true directly. Also > fix typo 'mirgate'. No functional change intended. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> --- > mm/memory-failure.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 2e97302d62e4..bd563f47630c 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1180,13 +1180,11 @@ void ClearPageHWPoisonTakenOff(struct page *page) > */ > static inline bool HWPoisonHandlable(struct page *page, unsigned long flags) > { > - bool movable = false; > - > - /* Soft offline could mirgate non-LRU movable pages */ > + /* Soft offline could migrate non-LRU movable pages */ > if ((flags & MF_SOFT_OFFLINE) && __PageMovable(page)) > - movable = true; > + return true; > > - return movable || PageLRU(page) || is_free_buddy_page(page); > + return PageLRU(page) || is_free_buddy_page(page); > } > > static int __get_hwpoison_page(struct page *page, unsigned long flags) > -- > 2.23.0 | |