Messages in this thread | | | Date | Mon, 11 Apr 2022 11:32:38 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] arch_topology: Do not set llc_sibling if llc_id is invalid |
| |
On Mon, Apr 11, 2022 at 09:37:36AM +0100, Sudeep Holla wrote: > Hi Qing, > > On Sun, Apr 10, 2022 at 07:36:19PM -0700, Qing Wang wrote: > > From: Wang Qing <wangqing@vivo.com> > > > > When ACPI is not enabled, cpuid_topo->llc_id = cpu_topo->llc_id = -1, which > > will set llc_sibling 0xff(...), this is misleading. > > > > Don't set llc_sibling(default 0) if we don't know the cache topology. > > > > Makes sense to me and thanks for splitting the patch and pointing this out > clearly. Your earlier patches mixed other things and made it hard to highlight > this one. > > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> > > Hi Greg, > > Can you pick this up ? IMO It can go as fix in -rc as it is kind of > misleading though I am not sure if it is breaking any platform.
Will do, thanks.
greg k-h
| |