lkml.org 
[lkml]   [2022]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] mmc-utils: Add General command CMD56 read support
From
Date
On Sat, 2022-04-09 at 09:03 +0000, Avri Altman wrote:
> > +       memset(&idata, 0, sizeof(idata));
> > +       idata.write_flag = 0;
> > +       idata.opcode = MMC_GEN_CMD;
> > +       idata.arg = arg;
> Practically arg is not needed, because bits[1..31] are meaningless.
> Maybe just set: idata.arg = 1;
>
> Thanks,
> Avri
Thanks for your review.

you are right arg is not needed according to eMMC spec. But as I
mentioned in the commit message, for the universal use. we need it for
the vendor-specific arg. I will change it that its arg will be 1 by
default if the user doesn't specific arg.

Kind regards,
Bean




\
 
 \ /
  Last update: 2022-04-11 10:53    [W:0.086 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site