lkml.org 
[lkml]   [2022]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] cdrom: do not print info list when there is no cdrom device
From
On 4/11/22 2:41 AM, Enze Li wrote:
>
> On 4/9/22 16:16, Phillip Potter wrote:
>> On Sat, Apr 09, 2022 at 12:25:30PM +0800, Enze Li wrote:
>
> <snip>
>
>>> On Fri, 8 Apr 2022 06:34:04 -0600
>>> Jens Axboe <axboe@kernel.dk> wrote:
>>>> Will this potentially break applications that parse it?
>>>>
>>> I dunno, is there any way to confirm this thing? And if this is really
>>> a possibility, does it mean that we cannot make changes?
>>>
>> Sorry, anything that can be parsed from userspace has the potential to
>> break userspace applications. For that reason, I would have to say I
>> don't think this patch is suitable. Sure there are times it's
>> appropriate to change userspace interfaces, but I'd rather err on the
>> side of caution here. Thanks for the patch though.
>>
>> Nacked-by: Phillip Potter <phil@philpotter.co.uk>
>>
>> Regards,
>> Phil
>
> Hi Phil,
>
> Thanks for your review. I got what you said. ?
>
> In addition, I noticed that in the source file[1], there is a Todo List there. I'm quite
> interested in it. It says:
> ================================================
> 17 To Do List:
> 18 ----------------------------------
> 19
> 20 -- Modify sysctl/proc interface. I plan on having one directory per
> 21 drive, with entries for outputing general drive information, and sysctl
> 22 based tunable parameters such as whether the tray should auto-close for
> 23 that drive. Suggestions (or patches) for this welcome!
> ================================================
> I'd like to know if the relevant patches are still welcome?
>
> IIUC, the TODO List says that we need to implement a modification of the
> following form:
> ----------------------------------------------------------------------------------------------------------
> $ tree /proc/sys/dev/cdrom
> /proc/sys/dev/cdrom
> |--sr0--autoclose
> | |-autoeject
> | |-check_media
> | |-debug
> | |-info
> | |-lock
> |
> |--sr1--autoclose
> | |-autoeject
> | |-check_media
> | |-debug
> | |-info
> | |-lock
> |
> |--sr2 ...
> .
> .
> .
> ----------------------------------------------------------------------------------------------------------
> I would appreciate it if you could give me some advice.

Let's not do that, this advice is perhaps 20 years old. /proc isn't to
be used for anything like that these days.

--
Jens Axboe

\
 
 \ /
  Last update: 2022-04-11 18:51    [W:0.071 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site