Messages in this thread | | | Date | Mon, 11 Apr 2022 08:32:05 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v2] opp: use list iterator only inside the loop |
| |
On 31-03-22, 16:30, Xiaomeng Tong wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a separate dedicated pointer variable [1]. > > In this case, use a new variable 'iter' as the list iterator, while > use the old variable 'new_dev' as a dedicated pointer to point to the > found entry. And BUG_ON(!new_dev);. > > [1]: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ > > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com> > ---
Applied. Thanks.
-- viresh
| |