lkml.org 
[lkml]   [2022]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3] drm/gma500: depend on framebuffer
    On Sun, Apr 10, 2022 at 9:40 PM James Hilliard
    <james.hilliard1@gmail.com> wrote:
    >
    > On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson
    > <patrik.r.jakobsson@gmail.com> wrote:
    > >
    > > On Sat, Apr 9, 2022 at 6:23 AM James Hilliard <james.hilliard1@gmail.com> wrote:
    > > >
    > > > Select the efi framebuffer if efi is enabled.
    > > >
    > > > This appears to be needed for video output to function correctly.
    > > >
    > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
    > >
    > > Hi James,
    > > EFI_FB is its own driver and not needed by gma500 to drive its
    > > hardware. What makes you think it's required?
    >
    > I wasn't getting any HDMI video output without it enabled for some reason,
    > I assume it is doing some sort of initialization needed by gma500
    > during startup.

    Then it sounds like you might just be using EFI_FB and not gma500. Can
    you provide the kernel log with drm.debug=0x1f set on kernel
    command-line.

    What machine is this? I've seen very few gma500 devices with UEFI.

    >
    > >
    > > -Patrik
    > >
    > > > ---
    > > > Changes v2 -> v3:
    > > > - select EFI_FB instead of depending on it
    > > > Changes v1 -> v2:
    > > > - use depends instead of select
    > > > ---
    > > > drivers/gpu/drm/gma500/Kconfig | 2 ++
    > > > 1 file changed, 2 insertions(+)
    > > >
    > > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
    > > > index 0cff20265f97..a422fa84d53b 100644
    > > > --- a/drivers/gpu/drm/gma500/Kconfig
    > > > +++ b/drivers/gpu/drm/gma500/Kconfig
    > > > @@ -2,11 +2,13 @@
    > > > config DRM_GMA500
    > > > tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
    > > > depends on DRM && PCI && X86 && MMU
    > > > + depends on FB
    > > > select DRM_KMS_HELPER
    > > > # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
    > > > select ACPI_VIDEO if ACPI
    > > > select BACKLIGHT_CLASS_DEVICE if ACPI
    > > > select INPUT if ACPI
    > > > + select FB_EFI if EFI
    > > > help
    > > > Say yes for an experimental 2D KMS framebuffer driver for the
    > > > Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and
    > > > --
    > > > 2.25.1
    > > >

    \
     
     \ /
      Last update: 2022-04-10 21:53    [W:8.885 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site