Messages in this thread | | | Subject | Re: [PATCH V8 7/7] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp | From | "Satya Priya Kakitapalli (Temp)" <> | Date | Fri, 1 Apr 2022 16:18:46 +0530 |
| |
On 4/1/2022 2:48 AM, Stephen Boyd wrote: > Quoting Satya Priya Kakitapalli (Temp) (2022-03-30 03:44:01) >> On 3/25/2022 11:18 PM, Stephen Boyd wrote: >>> #include "pm8008.dtsi" >>> >>> and then the nodes below. >> >> You mean >> >> pm8008_bus: &i2c1 { >> >> status = "okay"; >> >> }; >> >> &pm8008_bus { >> >> #include "pm8008.dtsi" >> >> }; >> >> and remaining nodes, right? >> > No. I meant what I wrote. >
Okay thank you for elaborating,
> &pm8008_bus: &i2c1 {
but this still needs to be "pm8008_bus: &i2c {" right.. no '&' before pm8008_bus.
> status = "okay"; > }; > > #include "pm8008.dtsi" > > and then the pm8008.dtsi file would have > > &pm8008_bus { > pm8008: pmic@8 { > compatible = "qcom,pm8008"; > ... > }; > > pm8008_regulators: regulators@9 { > compatible = "qcom,pm8008-regulators"; > ... > }; > }; > > and then this patch would modify those nodes with phandles.
| |