Messages in this thread | | | Date | Fri, 1 Apr 2022 09:30:13 +0100 | From | Giovanni Cabiddu <> | Subject | Re: [PATCH] crypto: testmgr - test in-place en/decryption with two sglists |
| |
On Sat, Mar 26, 2022 at 12:11:59AM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > As was established in the thread > https://lore.kernel.org/linux-crypto/20220223080400.139367-1-gilad@benyossef.com/T/#u, > many crypto API users doing in-place en/decryption don't use the same > scatterlist pointers for the source and destination, but rather use > separate scatterlists that point to the same memory. This case isn't > tested by the self-tests, resulting in bugs. > > This is the natural usage of the crypto API in some cases, so requiring > API users to avoid this usage is not reasonable. > > Therefore, update the self-tests to start testing this case. > > Signed-off-by: Eric Biggers <ebiggers@google.com> FWIW, I tried this with QAT and I don't see any issue.
Regards,
-- Giovanni
| |