lkml.org 
[lkml]   [2022]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm
From
Hi Rahul,

On 31/03/22 8:00 pm, Rahul T R wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Add the endpoint nodes to describe connection from
> DSS => MHDP => DisplayPort connector.
> Also add the phy link node and required pinmux nodes
> for hotplug.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
> .../dts/ti/k3-j721e-common-proc-board.dts | 78 ++++++++++++++++++-
> 1 file changed, 74 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index f5ca8e26ed99..8ddc0d3bd058 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -148,6 +148,28 @@
> pinctrl-0 = <&main_mcan2_gpio_pins_default>;
> standby-gpios = <&main_gpio0 127 GPIO_ACTIVE_HIGH>;
> };
> +
> + dp_pwr_3v3: fixedregulator-dp-prw {

Please use standard node name: regulator-X as per DT spec [1]


[1]
https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3

> + compatible = "regulator-fixed";
> + regulator-name = "dp-pwr";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */

Please use GPIO_ACTIVE_* macros as appropriate.

> + enable-active-high;
> + };
> +
[...]

\
 
 \ /
  Last update: 2022-04-01 07:04    [W:2.150 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site