Messages in this thread | | | Subject | Re: [PATCH] selftests/bpf: Return true/false (not 1/0) from bool functions | From | Shuah Khan <> | Date | Fri, 1 Apr 2022 09:58:10 -0600 |
| |
On 3/31/22 8:15 PM, Haowen Bai wrote: > Return boolean values ("true" or "false") instead of 1 or 0 from bool > functions. This fixes the following warnings from coccicheck: > > ./tools/testing/selftests/bpf/progs/test_xdp_noinline.c:567:9-10: WARNING: > return of 0/1 in function 'get_packet_dst' with return type bool > ./tools/testing/selftests/bpf/progs/test_l4lb_noinline.c:221:9-10: WARNING: > return of 0/1 in function 'get_packet_dst' with return type bool >
Thank you for including details on how the problem was found.
> Signed-off-by: Haowen Bai <baihaowen@meizu.com> > ---
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
| |