Messages in this thread | | | Date | Wed, 9 Mar 2022 16:42:41 +0100 | Subject | Re: [PATCH v1 0/4] Thermal library and tools | From | Daniel Lezcano <> |
| |
Hi Srinivas,
thanks for your feedbacks, I'll fix that.
-- Daniel
On 28/02/2022 18:13, srinivas pandruvada wrote: > Hi Daniel, > On Thu, 2022-02-24 at 22:41 +0100, Daniel Lezcano wrote: >> >> Hi, >> >> What shall I do with this series? Is everyone ok with it? >> > Some comments > 1. White space errors while applying > $git am ../daniel/\[PATCH\ v1\ 1_4\]\ tools_lib_thermal_\ Add\ a\ > thermal\ library.mbox > Applying: tools/lib/thermal: Add a thermal library > .git/rebase-apply/patch:234: trailing whitespace. > clean: > .git/rebase-apply/patch:715: trailing whitespace. > > nla_get_u32(attrs[THERMAL_GENL_ATTR_TZ_TEMP]), arg); > .git/rebase-apply/patch:878: trailing whitespace. > > .git/rebase-apply/patch:879: trailing whitespace. > struct thermal_handler; > .git/rebase-apply/patch:1103: trailing whitespace. > } > warning: squelched 5 whitespace errors > warning: 10 lines add whitespace errors. > > $git am ../daniel/\[PATCH\ v1\ 2_4\]\ tools_thermal_\ Add\ util\ > library.mbox > Applying: tools/thermal: Add util library > .git/rebase-apply/patch:152: trailing whitespace. > clean: > .git/rebase-apply/patch:259: trailing whitespace. > > .git/rebase-apply/patch:285: trailing whitespace. > > .git/rebase-apply/patch:385: trailing whitespace. > > .git/rebase-apply/patch:392: trailing whitespace. > /* > warning: squelched 1 whitespace error > warning: 6 lines add whitespace errors. > $git am ../daniel/\[PATCH\ v1\ 3_4\]\ tools_thermal_\ A\ temperature\ > capture\ tool.mbox > Applying: tools/thermal: A temperature capture tool > .git/rebase-apply/patch:165: trailing whitespace. > regex_t regex; > .git/rebase-apply/patch:205: trailing whitespace. > > .git/rebase-apply/patch:208: trailing whitespace. > > .git/rebase-apply/patch:249: trailing whitespace. > > .git/rebase-apply/patch:265: trailing whitespace. > > warning: squelched 13 whitespace errors > warning: 18 lines add whitespace errors. > > $ git am ../daniel/\[PATCH\ v1\ 4_4\]\ tools_thermal_\ Add\ thermal\ > daemon\ skeleton.mbox > Applying: tools/thermal: Add thermal daemon skeleton > .git/rebase-apply/patch:170: trailing whitespace. > } > .git/rebase-apply/patch:186: trailing whitespace. > > .git/rebase-apply/patch:197: trailing whitespace. > > .git/rebase-apply/patch:199: trailing whitespace. > > .git/rebase-apply/patch:348: trailing whitespace. > > warning: squelched 3 whitespace errors > warning: 8 lines add whitespace errors. > > > 2. No help or man page > thermal_engine has some options. There is no --help or man > > 3. Silent failure > > For example: > $sudo ./thermal-engine > > 4. > sudo ./thermometer > Options; > * config: 'thermometer.conf' > * log level: '7' > * postfix: -2022-02-28_16:51:33 > * output: . > > What an user can do? > > Thanks, > Srinivas > >> >> >> On 18/02/2022 13:53, Daniel Lezcano wrote: >>> This series provides a thermal library providing the basic callback >>> oriented >>> netlink communication and events with the thermal framework, a >>> temperature >>> capture tool and a thermal monitoring skeleton using the thermal >>> library. >>> >>> Changelog: >>> - V1: >>> - Took into account RFC comments (unsubscribe, error enum, >>> thermal daemon >>> renamed to thermal-engine) >>> >>> Daniel Lezcano (4): >>> tools/lib/thermal: Add a thermal library >>> tools/thermal: Add util library >>> tools/thermal: A temperature capture tool >>> tools/thermal: Add thermal daemon skeleton >>> >>> tools/Makefile | 36 +- >>> tools/lib/thermal/.gitignore | 2 + >>> tools/lib/thermal/Build | 5 + >>> tools/lib/thermal/Makefile | 165 ++++++++ >>> tools/lib/thermal/commands.c | 351 >>> ++++++++++++++++ >>> tools/lib/thermal/events.c | 164 ++++++++ >>> tools/lib/thermal/include/thermal.h | 141 +++++++ >>> tools/lib/thermal/libthermal.map | 25 ++ >>> tools/lib/thermal/libthermal.pc.template | 12 + >>> tools/lib/thermal/sampling.c | 75 ++++ >>> tools/lib/thermal/thermal.c | 126 ++++++ >>> tools/lib/thermal/thermal_nl.c | 215 ++++++++++ >>> tools/lib/thermal/thermal_nl.h | 46 ++ >>> tools/thermal/lib/Build | 3 + >>> tools/thermal/lib/Makefile | 158 +++++++ >>> .../thermal/lib/libthermal_tools.pc.template | 12 + >>> tools/thermal/lib/log.c | 77 ++++ >>> tools/thermal/lib/log.h | 31 ++ >>> tools/thermal/lib/mainloop.c | 135 ++++++ >>> tools/thermal/lib/mainloop.h | 14 + >>> tools/thermal/lib/thermal-tools.h | 10 + >>> tools/thermal/lib/uptimeofday.c | 40 ++ >>> tools/thermal/lib/uptimeofday.h | 12 + >>> tools/thermal/thermal-engine/Build | 2 + >>> tools/thermal/thermal-engine/Makefile | 27 ++ >>> tools/thermal/thermal-engine/thermal-engine.c | 287 +++++++++++++ >>> tools/thermal/thermometer/Build | 2 + >>> tools/thermal/thermometer/Makefile | 23 + >>> tools/thermal/thermometer/thermometer.c | 393 >>> ++++++++++++++++++ >>> tools/thermal/thermometer/thermometer.conf | 5 + >>> 30 files changed, 2591 insertions(+), 3 deletions(-) >>> create mode 100644 tools/lib/thermal/.gitignore >>> create mode 100644 tools/lib/thermal/Build >>> create mode 100644 tools/lib/thermal/Makefile >>> create mode 100644 tools/lib/thermal/commands.c >>> create mode 100644 tools/lib/thermal/events.c >>> create mode 100644 tools/lib/thermal/include/thermal.h >>> create mode 100644 tools/lib/thermal/libthermal.map >>> create mode 100644 tools/lib/thermal/libthermal.pc.template >>> create mode 100644 tools/lib/thermal/sampling.c >>> create mode 100644 tools/lib/thermal/thermal.c >>> create mode 100644 tools/lib/thermal/thermal_nl.c >>> create mode 100644 tools/lib/thermal/thermal_nl.h >>> create mode 100644 tools/thermal/lib/Build >>> create mode 100644 tools/thermal/lib/Makefile >>> create mode 100644 tools/thermal/lib/libthermal_tools.pc.template >>> create mode 100644 tools/thermal/lib/log.c >>> create mode 100644 tools/thermal/lib/log.h >>> create mode 100644 tools/thermal/lib/mainloop.c >>> create mode 100644 tools/thermal/lib/mainloop.h >>> create mode 100644 tools/thermal/lib/thermal-tools.h >>> create mode 100644 tools/thermal/lib/uptimeofday.c >>> create mode 100644 tools/thermal/lib/uptimeofday.h >>> create mode 100644 tools/thermal/thermal-engine/Build >>> create mode 100644 tools/thermal/thermal-engine/Makefile >>> create mode 100644 tools/thermal/thermal-engine/thermal-engine.c >>> create mode 100644 tools/thermal/thermometer/Build >>> create mode 100644 tools/thermal/thermometer/Makefile >>> create mode 100644 tools/thermal/thermometer/thermometer.c >>> create mode 100644 tools/thermal/thermometer/thermometer.conf >>> >> >> >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |