Messages in this thread | | | Date | Wed, 9 Mar 2022 13:00:45 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: tas5805m: fix pdn polarity |
| |
On Wed, Mar 09, 2022 at 12:34:28PM +0000, John Keeping wrote: > On Wed, Mar 09, 2022 at 12:12:47PM +0000, Mark Brown wrote: > > On Wed, Mar 09, 2022 at 10:41:04AM +0000, John Keeping wrote: > > > > > Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifier") > > > > Please don't insert fixes tags unless you're actually fixing a bug, > > stylistic improvements like this - people try to use the tag for > > backporting bug fixes and so on so extra tags create noise for them.
> This isn't purely stylistic - it affects the interpretation of pdn-gpios > in the device tree so that it matches all of the other bindings that use > this property: active means PDN asserted.
So there's some functional change? That's not at all clear from either the patch description or the code - it's flipping both the ACTIVE mode for the GPIO and all the values set which should result in no visible change. If there is a functional problem that is being fixed the description needs to be clear as to what that is. [unhandled content-type:application/pgp-signature] | |