lkml.org 
[lkml]   [2022]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 26/29] rtc: hym8563: let the core handle the alarm resolution
    Date
    Set RTC_FEATURE_ALARM_RES_MINUTE, so the core knows alarms have a
    resolution of a minute. Also, the core will properly round down the alarm
    instead of up.

    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    ---
    drivers/rtc/rtc-hym8563.c | 19 +------------------
    1 file changed, 1 insertion(+), 18 deletions(-)

    diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
    index ce4cbf0f48e7..78f21f623d89 100644
    --- a/drivers/rtc/rtc-hym8563.c
    +++ b/drivers/rtc/rtc-hym8563.c
    @@ -220,24 +220,6 @@ static int hym8563_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm)
    u8 buf[4];
    int ret;

    - /*
    - * The alarm has no seconds so deal with it
    - */
    - if (alm_tm->tm_sec) {
    - alm_tm->tm_sec = 0;
    - alm_tm->tm_min++;
    - if (alm_tm->tm_min >= 60) {
    - alm_tm->tm_min = 0;
    - alm_tm->tm_hour++;
    - if (alm_tm->tm_hour >= 24) {
    - alm_tm->tm_hour = 0;
    - alm_tm->tm_mday++;
    - if (alm_tm->tm_mday > 31)
    - alm_tm->tm_mday = 0;
    - }
    - }
    - }
    -
    ret = i2c_smbus_read_byte_data(client, HYM8563_CTL2);
    if (ret < 0)
    return ret;
    @@ -562,6 +544,7 @@ static int hym8563_probe(struct i2c_client *client,
    (ret & HYM8563_SEC_VL) ? "invalid" : "valid");

    hym8563->rtc->ops = &hym8563_rtc_ops;
    + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, hym8563->rtc->features);
    /* the hym8563 alarm only supports a minute accuracy */
    hym8563->rtc->uie_unsupported = 1;

    --
    2.35.1
    \
     
     \ /
      Last update: 2022-09-17 16:16    [W:4.384 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site