Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 9 Mar 2022 16:14:55 -0800 | Subject | Re: [PATCH] kgdbts: fix return value of __setup handler |
| |
Hi,
On Mon, Mar 7, 2022 at 7:33 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > __setup() handlers should return 1 to indicate that the boot option > has been handled. A return of 0 causes the boot option/value to be > listed as an Unknown kernel parameter and added to init's (limited) > environment strings. So return 1 from kgdbts_option_setup(). > > Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc7 > kgdboc=kbd kgdbts=", will be passed to user space. > > Run /sbin/init as init process > with arguments: > /sbin/init > with environment: > HOME=/ > TERM=linux > BOOT_IMAGE=/boot/bzImage-517rc7 > kgdboc=kbd > kgdbts= > > Fixes: e8d31c204e36 ("kgdb: add kgdb internal test suite") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru> > Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru > Cc: kgdb-bugreport@lists.sourceforge.net > Cc: Jason Wessel <jason.wessel@windriver.com> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/misc/kgdbts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |