lkml.org 
[lkml]   [2022]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv5 28/30] x86/tdx: ioapic: Add shared bit for IOAPIC base address
On 3/2/22 06:28, Kirill A. Shutemov wrote:
> +static void io_apic_set_fixmap_nocache(enum fixed_addresses idx,
> + phys_addr_t phys)
> +{
> + pgprot_t flags = FIXMAP_PAGE_NOCACHE;
> +
> + flags = pgprot_decrypted(flags);
> + __set_fixmap(idx, phys, flags);
> +}

This is only used by the "io_apic". No need to add the "_nocache". Maybe:

static void io_apic_set_fixmap(enum fixed_addresses idx, ...
{
pgprot_t flags = FIXMAP_PAGE_NOCACHE;

/*
* Ensure fixmaps for IOAPIC MMIO respect memory
* encryption pgprot bits, just like normal ioremap():
*/
flags = pgprot_decrypted(flags);

__set_fixmap(idx, phys, flags);
}

\
 
 \ /
  Last update: 2022-03-09 21:40    [W:0.801 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site