Messages in this thread | | | Date | Tue, 8 Mar 2022 18:10:05 +0100 | From | Alain Volmat <> | Subject | Re: [PATCH v1 1/1] media: c8sectpfe: Clean up handling of *_buffer_aligned |
| |
Hi Andy,
sorry for the delay.
Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>
Regards, Alain
On Tue, Mar 08, 2022 at 12:25:42PM +0200, Andy Shevchenko wrote: > +Hans (see below). > > On Wed, Mar 02, 2022 at 05:51:42PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 09, 2022 at 08:25:21PM +0200, Andy Shevchenko wrote: > > > There are a few cases where code is harder than needed to read. > > > Improve those by: > > > - dropping unnecessary castings (see note below) > > > - use PTR_ALING() to be more explicit on what's going on there > > > - use proper definitions instead of hard coded values > > > > > > Note, dropping castings will allow to perform an additional check > > > that type is not changed from void * to something else, e.g. u64, > > > which may very well break the bitmap APIs. > > > > Any comments on it? > > Can it be applied? > > -- > With Best Regards, > Andy Shevchenko > >
| |