lkml.org 
[lkml]   [2022]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 01/25] KVM: x86/mmu: avoid indirect call for get_cr3
From
On 3/8/22 17:32, Sean Christopherson wrote:
>
> Aha! An idea that would provide line of sight to avoiding retpoline in all cases
> once we use static_call() for nested_ops, which I really want to do... Drop the
> mmu hook entirely and replace it with:
>
> static inline kvm_mmu_get_guest_pgd(struct kvm_vcpu *vcpu)
> {
> if (!mmu_is_nested(vcpu))
> return kvm_read_cr3(vcpu);
> else
> return kvm_x86_ops.nested_ops->get_guest_pgd(vcpu);
> }

Makes sense, but I think you mean

static inline unsigned long kvm_mmu_get_guest_pgd(struct kvm_vcpu *vcpu,
struct kvm_mmu *mmu)
{
if (unlikely(vcpu == &vcpu->arch.guest_mmu))
return kvm_x86_ops.nested_ops->get_guest_pgd(vcpu);
else
return kvm_read_cr3(vcpu);
}

?

Paolo

\
 
 \ /
  Last update: 2022-03-08 17:44    [W:0.112 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site