Messages in this thread | | | Date | Tue, 8 Mar 2022 10:04:06 -0300 | Subject | Re: [PATCH V4] notifier/panic: Introduce panic_notifier_filter | From | "Guilherme G. Piccoli" <> |
| |
On 08/03/2022 09:54, Petr Mladek wrote: > [...] > Honestly, I am not that keen about enforcing the priorities. > > It would make sense only when the ordering is really important. > Then there should be some rules. It should be obvious why > something has to be done earlier than something else. > > From my POV, it is just another complexity. Someone will need to > assign the priority to the existing notifiers. People will wonder > about it for newly added notifiers. > > Reproducibility seems to be the only motivation. Is it really a > problem? Do the notifiers affect each other? > > Also the notifiers are typically registered by some early boot > code. It will define some ordering out of box. > > Best Regards, > Petr
OK Petr, makes sense. I feel that one the pros of the approach would be to document all the notifiers in the header, but I guess nothing prevents me to do that heh I don't need enforcing the priorities for this.
I liked the idea of having everything "reproducible" as you said, but we could face the problem of how to order some independent notifiers... would be something "ad-hoc".
I'll progress here without priorities for now, if somebody see an advantage for that, we can use it.
Thanks for your points,
Guilherme
| |