Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 8 Mar 2022 10:01:36 +0100 | Subject | Re: [RFC PATCH] memory: renesas-rpc-if: Correct QSPI data transfer in Manual mode |
| |
Hi Wolfram,
On Tue, Mar 8, 2022 at 9:46 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > This is not QSPI, but HF. > > Ah, okay. > > > Building a new firmware for R-Car H3 ES1.0 with HF unlocked will be > > complicated, as it is not supported by upstream TF-A. > > You mean QSPI here?
No, HF. Salvator-X(S) boots from HF.
> > Note that HF also fails to probe on R-Car M3-W and M3-N ES1.0. > > Do you have this patch form Andrew in your tree: > > [PATCH] memory: renesas-rpc-if: Avoid unaligned bus access for HyperFlash
Sure I have it. It's in v5.16 ;-)
> Even if so, I don't think that reverting patches is the solution. As you
Sure, a plain revert is definitely not the right solution.
> could see from Andrew's patch, HyperFlash was also broken before and it > just may need more fixes for Gen3 perhaps? IIRC my patches didn't break > Andrew's tests but maybe we should ask him again. Maybe Andrew has also > some more ideas, I only did QSPI.
My understanding from reading the threads is that Andrew's patch and yours arrived in parallel, and are believed to fix two different and non-intersecting things (QSPI vs. HF). I also found no explicit mention that Andrew tried your patch.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |