Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 8 Mar 2022 14:12:34 -0800 | Subject | Re: [PATCH] kgdboc: fix return value of __setup handler |
| |
Hi,
On Tue, Mar 8, 2022 at 1:19 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > Hi Doug, > > >> Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc7 > >> kgdboc=kbd kgdbts=", will be passed to user space. > >> > >> Run /sbin/init as init process > >> with arguments: > >> /sbin/init > >> with environment: > >> HOME=/ > >> TERM=linux > >> BOOT_IMAGE=/boot/bzImage-517rc7 > >> kgdboc=kbd > >> kgdbts= > >> > >> Fixes: 1cd25cbb2fed ("kgdboc: Fix warning with module build") > > > > Are you certain about this "Fixes" line? That commit was just code > > motion to move the code inside the #ifdef. It sure looks like it was > > broken even before this. > > > > Yes, but I am not enough of a git user to be able to backtrack > to see where this code was added. :( > (help?)
I always just chain back w/ git blame. In this case:
git blame 1cd25cbb2fed~ -- drivers/tty/serial/kgdboc.c
...then search for __setup there and it finds:
Fixes: f2d937f3bf00 ("consoles: polling support, kgdboc")
| |