lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 26/32] soc: fsl: qe: Check of ioremap return value
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit a222fd8541394b36b13c89d1698d9530afd59a9c ]

    As the possible failure of the ioremap(), the par_io could be NULL.
    Therefore it should be better to check it and return error in order to
    guarantee the success of the initiation.
    But, I also notice that all the caller like mpc85xx_qe_par_io_init() in
    `arch/powerpc/platforms/85xx/common.c` don't check the return value of
    the par_io_init().
    Actually, par_io_init() needs to check to handle the potential error.
    I will submit another patch to fix that.
    Anyway, par_io_init() itsely should be fixed.

    Fixes: 7aa1aa6ecec2 ("QE: Move QE from arch/powerpc to drivers/soc")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Signed-off-by: Li Yang <leoyang.li@nxp.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/fsl/qe/qe_io.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/soc/fsl/qe/qe_io.c b/drivers/soc/fsl/qe/qe_io.c
    index 7ae59abc7863..127a4a836e67 100644
    --- a/drivers/soc/fsl/qe/qe_io.c
    +++ b/drivers/soc/fsl/qe/qe_io.c
    @@ -41,6 +41,8 @@ int par_io_init(struct device_node *np)
    if (ret)
    return ret;
    par_io = ioremap(res.start, resource_size(&res));
    + if (!par_io)
    + return -ENOMEM;

    num_ports = of_get_property(np, "num-ports", NULL);
    if (num_ports)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-03-07 10:22    [W:7.146 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site