Messages in this thread | | | Date | Mon, 7 Mar 2022 09:15:41 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH v2] mm/page_alloc: call check_new_pages() while zone spinlock is not held |
| |
On Fri, Mar 04, 2022 at 09:02:15AM -0800, Eric Dumazet wrote: > From: Eric Dumazet <edumazet@google.com> > > For high order pages not using pcp, rmqueue() is currently calling > the costly check_new_pages() while zone spinlock is held, > and hard irqs masked. > > This is not needed, we can release the spinlock sooner to reduce > zone spinlock contention. > > Note that after this patch, we call __mod_zone_freepage_state() > before deciding to leak the page because it is in bad state. > > v2: We need to keep interrupts disabled to call __mod_zone_freepage_state() > > Signed-off-by: Eric Dumazet <edumazet@google.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Vlastimil Babka <vbabka@suse.cz> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Shakeel Butt <shakeelb@google.com> > Cc: Wei Xu <weixugc@google.com> > Cc: Greg Thelen <gthelen@google.com> > Cc: Hugh Dickins <hughd@google.com> > Cc: David Rientjes <rientjes@google.com>
Ok, this is only more expensive in the event pages on the free list have been corrupted whch is already very unlikely so thanks!
Acked-by: Mel Gorman <mgorman@techsingularity.net>
-- Mel Gorman SUSE Labs
| |